Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Conversation

@j4w8n
Copy link
Contributor

@j4w8n j4w8n commented Jan 6, 2025

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Type checking and/or linting does not pass for some configurations, per #967 and #1017

What is the new behavior?

We're now asserting that parts[1] is a string (aka isn't undefined), since we know from a previous check that the array length is 3.

Additional context

Fixes #967 and fixes #1017

@ganeshrvel
Copy link

Any updates on this PR? This bug is causing issues with my typecheck pipleline

@kangmingtay kangmingtay reopened this Jan 29, 2025
@kangmingtay
Copy link
Member

closed and reopen to retrigger CI checks 🤷

@kangmingtay kangmingtay merged commit 3d80039 into supabase:master Jan 29, 2025
4 checks passed
kangmingtay pushed a commit that referenced this pull request Mar 24, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.69.0](v2.68.0...v2.69.0)
(2025-03-22)


### Features

* introduce getClaims method to verify asymmetric JWTs
([#1030](#1030))
([daa2669](daa2669))


### Bug Fixes

* assert type in `decodeJWTPayload`
([#1018](#1018))
([3d80039](3d80039))
* set jwks_cached_at
([#1039](#1039))
([9bdc023](9bdc023))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mandarini pushed a commit to supabase/supabase-js that referenced this pull request Oct 2, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.69.0](supabase/auth-js@v2.68.0...v2.69.0)
(2025-03-22)


### Features

* introduce getClaims method to verify asymmetric JWTs
([#1030](supabase/auth-js#1030))
([6d12676](supabase/auth-js@6d12676))


### Bug Fixes

* assert type in `decodeJWTPayload`
([#1018](supabase/auth-js#1018))
([1a78f42](supabase/auth-js@1a78f42))
* set jwks_cached_at
([#1039](supabase/auth-js#1039))
([0f79bce](supabase/auth-js@0f79bce))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

3 participants