Skip to content

Conversation

@sonjek
Copy link
Contributor

@sonjek sonjek commented Apr 27, 2024

saml-plugin is used for configuring SSO, and it has its own security key saml-jenkins-keystore.jks, which also needs to be included in backups.

I propose to store *.jks files additionally.

@sue445
Copy link
Owner

sue445 commented Apr 27, 2024

@sonjek Please fix failed tests

@sonjek
Copy link
Contributor Author

sonjek commented Apr 27, 2024

Hi, tests failed on missed new test file jenkins-backup/saml-jenkins-keystore.jks.
A temporary removed new value from spec/jenkins-backup_spec.rb

I tested it manually when I made a backup of our servers.
If it needs to be tested, then, please advice, how I can create this file for archive in tests?

@sue445 sue445 self-requested a review April 27, 2024 15:21
Copy link
Owner

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonjek
Copy link
Contributor Author

sonjek commented Apr 27, 2024

@sue445 I've added testing for JENKINS_HOME/*.jks archiving. Looks ok now.

@sue445 sue445 merged commit 37f000c into sue445:master Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants