Make it all work again #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your PR is causing a problem with the event slider, you can test it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @strukturart, several small things were broken and this fixes it mostly on a desktop browser.
I just can't get it to work now on my phone though. :(
Could you tell what version of npm, node and parcel are you using? That might be it. Without doing an "npm install" I get a hanging "parcel", with running it, I have many changes in yarn.lock, package.json, package-lock.json.
Then after installing on the phone, apparently some library code (included in the index.js...) says "Invalid character in header field name", because it tries to parse a header value as a header name.