Skip to content

Conversation

zeekoe
Copy link

@zeekoe zeekoe commented Feb 1, 2024

Hi John-David, I made some changes to make it work better in a Desktop browser

  • support routes without / (without this the app will fail completely; a regression since a few months)
  • use 'm' in another location too as alternative for 'Alt' (because 'Alt' opens the menu; preventDefault doesn't work in recent FF)
  • prevent registering more than one service worker

@strukturart
Copy link
Owner

thank you for your help!
would it be possible to change the function name? am_i_on_page() = currentPage() ?

- support routes without /
- use 'm' in another location too as alternative for 'Alt'
- prevent registering more than one service worker
@zeekoe zeekoe force-pushed the desktop-browser-tweaks branch from 61b0492 to 674f60a Compare February 1, 2024 15:33
@zeekoe
Copy link
Author

zeekoe commented Feb 1, 2024

You're welcome ;) After you writing this great app and helping me out, the least I can do is contribute back what I write myself! :-)
Changed the function name.

@strukturart strukturart merged commit 674f60a into strukturart:master Feb 1, 2024
@zeekoe zeekoe deleted the desktop-browser-tweaks branch February 22, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants