-
Notifications
You must be signed in to change notification settings - Fork 483
swarm - switch to handoff node only after current node stops #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…nto swarm-handoff-delayed
…nto swarm-handoff-delayed
dbschmigelski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a unit test so we don't accidentally break the ordering in the future
…nto swarm-handoff-delayed
Done |
Description
Set the handoff node to current only after the current node finishes. Currently, we make the switch in the middle of the current node execution. It is important to fix this for a few reasons:
AfterNodeCallEventwith the current node id andstate.current_nodeset to the handoff node. This is going to cause customer confusion.Related Issues
#204
Documentation PR
Implementation detail
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare: Relying on existing unit testshatch test tests_integ/test_multiagent_swarm.pyChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.