Skip to content
This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Move API version to v1 #86

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Move API version to v1 #86

merged 1 commit into from
Mar 26, 2019

Conversation

darkowlzz
Copy link
Contributor

This changes the API version of all the CRDs from v1alpha1 to v1.

@darkowlzz darkowlzz requested a review from domodwyer as a code owner March 25, 2019 16:28
@darkowlzz darkowlzz force-pushed the api-version-v1 branch 3 times, most recently from 6da8ddb to f036d2e Compare March 25, 2019 17:07
@darkowlzz darkowlzz requested a review from croomes as a code owner March 25, 2019 17:07
@darkowlzz
Move API version to v1
0552875 
This changes the API version of all the CRDs from v1alpha1 to v1.
@darkowlzz darkowlzz changed the title [WIP] Move API version to v1 Move API version to v1 Mar 25, 2019
@darkowlzz
Copy link
Contributor Author

darkowlzz commented Mar 25, 2019 •
edited
Loading

deploy/examples.json and deploy/olm/storageos/ still have v1alpha1 api version because they are related to the OLM CSV file which targets a specific version of the operator. They should be updated once we have a v1 api version release available.

croomes
croomes approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@croomes croomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Adding Paul for visibility as this is a breaking change. Clusters installed with previous versions of the Operator will not be manageable by 1.0.0 Operator as we're moving the StorageOS API objects from alpha to stable.

We want to do this before getting 1.0.0 on the Operator Hub and certified.

deploy/storageos-operators.configmap.yaml
channels:
- name: alpha
- name: stable
currentCSV: storageosoperator.0.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 0.0.0 correct?

Copy link
Contributor Author

@darkowlzz darkowlzz Mar 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is used in the e2e test only. We need not increment it every time.

@croomes croomes requested a review from actionbuddha March 25, 2019 17:34
@actionbuddha actionbuddha requested review from Arau and avestuk March 25, 2019 17:37
@actionbuddha
Copy link

Adding @avestuk and @Arau for commentary and awareness - guys, be aware this is a breaking change.

@domodwyer
Copy link
Contributor

I noticed the Default Value for images.nodeContainer on the readme says storageos/node:1.1.0 - I guess this should be 1.1.4 and changing it part of the release checklist @actionbuddha ?

@darkowlzz darkowlzz merged commit a4a87b1 into storageos:master Mar 26, 2019
@darkowlzz darkowlzz deleted the api-version-v1 branch March 26, 2019 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@actionbuddha actionbuddha Awaiting requested review from actionbuddha

@Arau Arau Awaiting requested review from Arau

@avestuk avestuk Awaiting requested review from avestuk

2 more reviewers

@croomes croomes croomes approved these changes

@domodwyer domodwyer domodwyer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@darkowlzz @actionbuddha @domodwyer @croomes