This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
cluster: fix cluster status update #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine current cluster and deployment in to a single data type StorageOSCluster so that the deployment always points to the right cluster. Also, adds status members checks in e2e test and enables go race detector for the unit tests.
darkowlzz
force-pushed
the
fix-cluster-status-update
branch
from
c5f275d to
7b169f4
Compare
croomes
approved these changes
Mar 18, 2019
pkg/storageos/daemonset.go
Outdated
| // FieldRef: &corev1.ObjectFieldSelector{ | ||
| // FieldPath: "status.podIP", | ||
| // }, | ||
| // }, |
There was a problem hiding this comment.
Yes, we should remove that. We will not need that again.
Deployment interface defines a cluster deployment for StorageOSCluster.
darkowlzz
force-pushed
the
fix-cluster-status-update
branch
from
7b169f4 to
3796b20
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine current cluster and deployment in to a single data type
StorageOSCluster so that the deployment always points to the right
cluster.
Also, adds status members checks in e2e test and enables go race detector
for the unit tests.