This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Set priority class for helper pods #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmxs
approved these changes
May 12, 2021
darkowlzz
reviewed
May 12, 2021
| // Prior to StorageOS v2.4.0, the priority class was only set for Pods running | ||
| // in the kube-system namespace, as k8s 1.16 and earlier would only allow this. | ||
| func (s *Deployment) addPodPriorityClass(podSpec *corev1.PodSpec, priorityClass string) { | ||
| podSpec.PriorityClassName = priorityClass |
There was a problem hiding this comment.
Getting rid of the kube-system namespace conditional, finally 😃
Maybe the comment about kube-system above is not necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the
system-cluster-criticalpriority class on StorageOS pods that must be running somewhere in the cluster. This allows the Pod to move to another node if it doesn't tolerate a taint (such as memory pressure) but ensures it runs somewhere.