Skip to content
This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Conversation

croomes
Copy link
Contributor

@croomes croomes commented Mar 16, 2021

Sets default tolerations on the non-critical helper pods.

By default, the helpers will tolerate node.kubernetes.io/disk-pressure and the default TolerationSeconds for node.kubernetes.io/not-ready and node.kubernetes.io/unreachable is reduced from 300 to 30s.

  • Allows defaults to be overridden by tolerations set in the StorageOSCluster spec.
  • Removes the deprecated node.kubernetes.io/out-of-disk toleration.
  • Sorts tolerations on key name to ensure idempotency.

@croomes croomes requested review from avestuk and darkowlzz March 16, 2021 14:35
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.
Added a few inline comments.
Thanks.

@croomes croomes merged commit 0c998c4 into master Mar 17, 2021
@croomes croomes deleted the scheduler-tolerations branch March 17, 2021 16:07
croomes added a commit that referenced this pull request Mar 17, 2021
* Toleration defaults for helper pods

* Apply common properties to scheduler
croomes added a commit that referenced this pull request Mar 23, 2021
* Toleration defaults for helper pods

* Apply common properties to scheduler
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants