This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Use CSI attacher v3 for k8s 1.17+ #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avestuk
approved these changes
Feb 5, 2021
darkowlzz
approved these changes
Feb 8, 2021
croomes
added a commit
that referenced
this pull request
Feb 8, 2021
* Use v3 CSI attacher for k8s 1.17+ * Add role required for csi attacher v3
croomes
added a commit
that referenced
this pull request
Feb 8, 2021
* Use v3 CSI attacher for k8s 1.17+ * Add role required for csi attacher v3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides VolumeAttachment reconciliation via the ListVolumes() CSI call. With reconciliation in place, StorageOS can tell the attacher that a volume is no longer attached and that it requires re-attaching before attempting a mount.
The v3 attacher requires k8s 1.17+ to run. The reconcile feature was merged in v2, but the patch needed for it to work (kubernetes-csi/external-attacher#244) was only merged in v3. k8s 1.16 and earlier will use the v2 attacher which does not support reconciliation.