Skip to content
This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Conversation

croomes
Copy link
Contributor

@croomes croomes commented Jan 21, 2021

Travis jobs should logon to the Docker Hub prior to running commands that pull images.

This avoids recent CI errors:

1.15.2: Pulling from library/golang
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
Makefile:159: recipe for target 'operator-image' failed
make: *** [operator-image] Error 1
The command "make operator-image" exited with 2.

@croomes croomes requested a review from darkowlzz January 21, 2021 17:24
sudo: required
name: Publish Container Image
before_script:
- docker login -u "$REGISTRY_USER" -p "$REGISTRY_PASS"
Copy link
Contributor

@darkowlzz darkowlzz Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we log in here, the same in before_deploy (below line # 67) can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying it now...

@croomes croomes requested a review from darkowlzz January 22, 2021 14:01
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@croomes croomes merged commit 5e41598 into master Jan 22, 2021
@croomes croomes deleted the e2e-docker-creds branch January 22, 2021 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants