Use fugit #68
Merged
Use fugit #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usbalbin
commented
Apr 21, 2023
| @@ -1,170 +1,114 @@ | |||
| use core::ops::{Add, Div}; | |||
| pub use fugit::{ | |||
Member
Author
There was a problem hiding this comment.
The contents of this file is now more or less identical with the one from stm32g0xx-hal
usbalbin
commented
Apr 21, 2023
| impl CountDown for CountDownTimer<SYST> { | ||
| type Time = Hertz; | ||
| impl embedded_hal::timer::CountDown for CountDownTimer<SYST> { | ||
| type Time = MicroSecond; |
Member
Author
There was a problem hiding this comment.
I realize Hertz -> MicroSecond is quite a big change, it felt more natural in my mind. However I am fine with reverting that...
usbalbin
added a commit
to usbalbin/stm32g4xx-hal
that referenced
this pull request
Jun 7, 2023
* Use fugit for time related types to make the crate more consistent with stm32g0xx-hal * fmt
Member
Author
|
Any thoughts on this? Is this something that is wanted or should I close this PR? Also please let me know if you want me to change anything :) |
no111u3
approved these changes
Nov 27, 2023
Member
Author
|
Thanks a lot :) @no111u3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first started with me trying to implement rtc for this crate by stealing it from stm32g0xx-hal. I noticed there were some differences.
This PR changes the time related types to use fugit to make the crate a bit more consistent with stm32g0xx-hal.
Is this at all something we want?
(Not at all tested on real hardware yet)- Some testing done