[6.x] Table fixes for Safari and Firefox #12233
Merged
+33
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adjustment. In Firefox’s implementation, tbody’s background and border properties aren’t rendered as a box, so your border-radius has no visual effect. Instead we need to style the tds
Similar to Firefox, tbody’s properties aren’t rendered as a box, so your box-shadows have no visual effect. Instead we need to style the tds with borders instead of shadows. I've added an alternative shadow for browsers like Chrome to compensate for the border
|
Does shadow-sm-b need to be added? It looks pretty much identical to shadow-sm. |
|
@jasonvarga because I've added a hairline border around the whole table, if we use the existing
Short answer… yes, please! Unfortunately, stock Tailwind doesn't have directional shadows, which is why I added it 😃 |
|
Ah I was going to point out the shadow is different to how it was anyway and that there's a border now. But if it's intentional cool 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes table border-radius for Firefox, along with a hover state adjustment.
It also improves things for Safari.
This closes #12070
Firefox
In Firefox’s implementation, tbody’s background and border properties aren’t rendered as a box, so border-radius has no visual effect.
Instead, I've styled the tds.
Safari
Similar to Firefox, in WebKit (Safari), any background, borders, or box-shadow applied to tbody are simply ignored — the browser paints only the table itself and its cells. Instead, our only option is to style the tds with borders instead of shadows. I've added an alternative shadow for browsers like Chrome to compensate for the new border.