Skip to content

Conversation

@jamesfisher-geo
Copy link
Collaborator

@jamesfisher-geo jamesfisher-geo commented Jan 29, 2025

Related Issue(s):

Description:

  • Upgrade pygeofilter to 0.3.1
  • Resolves the issue with non-functional IsNull operator described in IS NULL filter operator #300.
  • Includes a bugfix for datetime querying
  • Typo fix :)

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog


field = to_es_field(query["args"][0]["property"])
value = query["args"][1]
if isinstance(value, dict) and "timestamp" in value:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug here where datetime filtering using a range_op was returning an empty dict with pygeofilter 0.3.1

Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@jamesfisher-geo jamesfisher-geo merged commit 125baff into main Feb 2, 2025
15 checks passed
@jonhealy1 jonhealy1 deleted the isnull branch May 15, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants