Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

[FR] Add method PGPPayload() for tag and commit #1116

@sapk

Description

@sapk

Before doing a PR I would like to know your if it would be accepted and what it should look like to be accepted.

Currently only the full Encode method of a commit/tag is exposed publicly. In the goal of being able to verify the payload directly from a keyring and not a armored key string like the Verify method of tag and commit, I would suggest to add another method like PGPPayload() string that export the result of t.encode(o, false). This method could also be re-use in the Verify of commit and tag.

I mainly ask because it doesn't follow the contributing rule: You should be able to run the same query using git. We don't accept features that are not implemented in the official git implementation. as I don't think we can export without the sig with the git cli. But this method would be very useful and limit the duplication of code in and outside go-git to do the same.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions