Skip to content

Update documentation code snippet to ensure feedback widget displays after instant navigation #8275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Update documentation code snippet to ensure feedback widget displays after instant navigation #8275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions docs/setup/setting-up-site-analytics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,25 +273,29 @@ generated by users interacting with the feedback widget with the help of some
=== ":octicons-file-code-16: `docs/javascripts/feedback.js`"

``` js
var feedback = document.forms.feedback
feedback.hidden = false // (1)!

feedback.addEventListener("submit", function(ev) {
ev.preventDefault()

var page = document.location.pathname // (2)!
var data = ev.submitter.getAttribute("data-md-value")

console.log(page, data) // (3)!

feedback.firstElementChild.disabled = true // (4)!

var note = feedback.querySelector(
".md-feedback__note [data-md-value='" + data + "']"
)
if (note)
note.hidden = false // (5)!
})
document$.subscribe(function() {
var feedback = document.forms.feedback
if (typeof feedback === "undefined") return

feedback.hidden = false // (1)!

feedback.addEventListener("submit", function(ev) {
ev.preventDefault()

var page = document.location.pathname // (2)!
var data = ev.submitter.getAttribute("data-md-value")

console.log(page, data) // (3)!

feedback.firstElementChild.disabled = true // (4)!

var note = feedback.querySelector(
".md-feedback__note [data-md-value='" + data + "']"
)
if (note)
note.hidden = false // (5)!
})
}
```

1. The feedback widget is hidden by default so that it does not appear when
Expand Down