Bump clang-format to 19.1.4 #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
amorde
commented
Aug 22, 2025
amorde
commented
- Bump clang-format to 19.1.4 built from https://github.com/swiftlang/llvm-project/releases/tag/swift-6.1.1-RELEASE
- Update .clang-format based on new settings introduced since version 12
amorde
commented
Aug 22, 2025
| /usr/bin/python3 "$DIR"/custom/GenericCategoryLinebreakIndentation.py | | ||
| /usr/bin/python3 "$DIR"/custom/ParameterAfterBlockNewline.py | | ||
| /usr/bin/python3 "$DIR"/custom/HasIncludeSpaceRemover.py | | ||
| /usr/bin/python3 "$DIR"/custom/NewLineAtEndOfFileInserter.py |
There was a problem hiding this comment.
this is obsolete now that clang-format includes an option to force a newline before EOF via InsertNewlineAtEOF: true
amorde
commented
Aug 22, 2025
| @@ -97,8 +97,8 @@ @interface Foo | |||
| Update(UpdateType t, const Slice &v) : type(t), value(v.data(), v.size()) {} | |||
| }; | |||
|
|
|||
| /* Same deal here, don't mess with adding newlines after this comment block | |||
| * with a different comment style | |||
There was a problem hiding this comment.
these unfortunately produce a large amount of changes in our repo, but I can't seem to find which setting controls this behavior. I looked at all of the settings here marked with clang-format {XYZ} where XYZ was 13-19
amorde
commented
Aug 22, 2025
| success(model); | ||
| } | ||
| }, failure); | ||
| return INSAPIClientModelSuccessChain(mantleClass, keyPath, ^(__kindof INSModel *model, id _) { |
There was a problem hiding this comment.
I believe this might be controlled by https://clang.llvm.org/docs/ClangFormatStyleOptions.html#lambdabodyindentation but its not clear if there's a way to not change these. However, the new version seems nicer IMO.
square-tomb
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.