Cache string normalization (3c/3) #573
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* maxg/cache_1_equiv: Fix testkey
* maxg/cache_2_envcache: Fix testkey
* maxg/cache_1_equivalency: include other TestKeys Fix testkey
* maxg/cache_2_envcache: include other TestKeys Fix testkey
* maxg/cache_1_equivalency: Cleanup
* maxg/cache_2_envcache: Merge. Cleanup
maxg-square
changed the title
maxg-square
changed the title
* maxg/cache_2_envcache: More tests Tests and fixes
* maxg/cache_2_envcache: Tweak env tests More tests
maxg-square
force-pushed
the
maxg/cache_2_envcache
branch
from
5d53aa4 to
84fe9bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3c/3 for caching changes.
Big-picture PR here: https://github.com/square/Blueprint/pull/574/files
Design doc: https://docs.google.com/document/d/1CLhFbzZGbEKgvZTUwLuGbFY-rfZNJVTi6f3PkoZT9qI/edit?usp=sharing
Adds support for caching
AttributedLabelstring normalization results.