Working on Grails 3.3.9 #32
Open
+248
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he documentation plugin bootstrap from starting until Grails has started. This resolves the issue with the GORM startup exception
….web.Action, the method with grails.web.Action is created during AST
…o fix-controller-lowercase
Since BookController does not extends RestfulController, theses adjustments were necessary
Changes lower case to camel case
|
Hi. Will this pull request be merged into master? |
|
I spent some time testing this fork in a project with grails 3.3.9. Summary:
Some caveats from my review:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @igoraguiar from #31 . Just fix CI failure.
TODO: Fix deprecated
GrailsDomainClass.