parameter of type com.querydsl.core.types.Predicate ignored when unique

[metcox]

When an operation has a single parameter of type com.querydsl.core.types.Predicate annotated with @QuerydslPredicate, the generated schema does not expose the expected input query param.

Let's say we have the following operation:

@RequestMapping(method = RequestMethod.GET, value = "/operation")
@ResponseBody
public String operation(@QuerydslPredicate(root = MyUser.class) Predicate predicate) {
    return "hi";
}

we get something like

"/auth/operation":
    {"get":{
        "operationId":"operation",
        "responses":{"200":{"content":{"*/*":{"schema":{"type":"string"}}}}}
    }}

With a additional parameter:

@RequestMapping(method = RequestMethod.GET, value = "/operation")
@ResponseBody
public String operation(@QuerydslPredicate(root = MyUser.class) Predicate predicate, String param) {
    return "hi";
}

we get something like

"/auth/operation":
    {"get":{
        "operationId":"operation",
        "parameters":[
            {"name":"param","in":"query","required":true,"schema":{"type":"string"}},
            {"name":"firstName","in":"query","schema":{"type":"string"}}
        ],
        "responses":{"200":{"content":{"*/*":{"schema":{"type":"string"}}}}}
    }}

where firstName is a field of MyUser POJO.

The QuerydslPredicateOperationCustomizer class only customize the operation if parameters are found.

springdoc-openapi/springdoc-openapi-data-rest/src/main/java/org/springdoc/data/rest/customisers/QuerydslPredicateOperationCustomizer.java

Lines 88 to 91 in c56df04

	public Operation customize(Operation operation, HandlerMethod handlerMethod) {
	if (operation.getParameters() == null) {
	return operation;
	}

However parameters of type Predicate are ignored

springdoc-openapi/springdoc-openapi-data-rest/src/main/java/org/springdoc/data/rest/SpringDocDataRestConfiguration.java

Lines 114 to 120 in 5889678

	QuerydslPredicateOperationCustomizer queryDslQuerydslPredicateOperationCustomizer(Optional<QuerydslBindingsFactory> querydslBindingsFactory) {
	if (querydslBindingsFactory.isPresent()) {
	getConfig().addRequestWrapperToIgnore(Predicate.class);
	return new QuerydslPredicateOperationCustomizer(querydslBindingsFactory.get());
	}
	return null;
	}

[bnasslahsen]

Not reproducible.
Try providing a Minimal, Reproducible Example - with HelloController that reproduces the problem

[metcox]

Hello @bnasslahsen,

Sorry for the inconvenience.
You will find a reproducible exemple here: metcox@42d281e
the output does not contains any parameter but should have two.

[bnasslahsen]

@metcox,

Exactly, agree.