Skip to content

Add support ResolvableTypeProvider to AuthorizationEvent #16762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

Add support ResolvableTypeProvider to AuthorizationEvent #16762

merged 2 commits into from
Mar 20, 2025

Conversation

@franticticktick
Copy link
Contributor

@franticticktick franticticktick commented Mar 18, 2025

Closes gh-16700

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 18, 2025
@jzheaux jzheaux self-assigned this Mar 19, 2025
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 19, 2025
@jzheaux jzheaux added this to the 6.5.0-RC1 milestone Mar 19, 2025
jzheaux
jzheaux requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @franticticktick! I've left feedback inline.

@franticticktick franticticktick requested a review from jzheaux March 20, 2025 09:22
@jzheaux
Add Authorization Event Tests
9179db9 
- These ensure that the parameterized version of authorization events
can be listened to

Issue spring-projectsgh-16700
@jzheaux jzheaux merged commit c91656c into spring-projects:main Mar 20, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Mar 20, 2025

Thanks for the PR, @franticticktick! Note that I added 9179db9 to include tests.

Even for simple features like these, tests are helpful for two reasons:

  1. Ensure that a feature works. This also helps us have a test to point to when troubleshooting an issue with a reporter.
  2. Shows a sample of how to use the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels

in: core An issue in spring-security-core type: enhancement A general enhancement

Projects

None yet

Milestone

6.5.0-RC1

Development

Successfully merging this pull request may close these issues.

AuthorizationDenied and Granted EventListeners Should Support Generics

3 participants

@franticticktick @jzheaux @spring-projects-issues