Allow configuring custom ServerHttpHeadersWriter for Kotlin DSL #16136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
evgeniycheban
force-pushed
the
gh-16009
branch
2 times, most recently
from
9dc0509 to
7c59a4d
Compare
jzheaux
added
in: config
jzheaux
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Thanks, @evgeniycheban! Could we avoid adding the extra DSL layer? Please see my inline comment for more details.
config/src/test/kotlin/org/springframework/security/config/web/server/ServerHeadersDslTests.kt
Outdated
Show resolved
Hide resolved
evgeniycheban
force-pushed
the
gh-16009
branch
from
7c59a4d to
ef3f46c
Compare
|
Hi, @jzheaux I just updated PR according to your comments. |
jzheaux
approved these changes
Dec 9, 2024
|
Great, @evgeniycheban. We'll go ahead and merge this after we cut the |
|
@jzheaux should I add |
|
@evgeniycheban, yes please, and thank you. |
evgeniycheban
force-pushed
the
gh-16009
branch
from
ef3f46c to
cf572a9
Compare
|
@jzheaux I added |
|
Thanks, @evgeniycheban, for the PR! It was nice to work with you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16009