Skip to content

Update toSting() methods in KafkaEvent subclasses #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Update toSting() methods in KafkaEvent subclasses #3502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2d3c29
Fix `toSting()` methods in `KafkaEvent` subclasses
bky373 Sep 16, 2024
358a766
Fix typo in `events.adoc`
bky373 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spring-kafka-docs/src/main/antora/modules/ROOT/pages/kafka/events.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ The following Spring application events are published by listener containers and
* `ConsumerFailedToStartEvent`: published if no `ConsumerStartingEvent` is published within the `consumerStartTimeout` container property.
This event might signal that the configured task executor has insufficient threads to support the containers it is used in and their concurrency.
An error message is also logged when this condition occurs.
* `ListenerContainerIdleEvent`: published when no messages have been received in `idleInterval` (if configured).
* `ListenerContainerIdleEvent`: published when no messages have been received in `idleEventInterval` (if configured).
* `ListenerContainerNoLongerIdleEvent`: published when a record is consumed after previously publishing a `ListenerContainerIdleEvent`.
* `ListenerContainerPartitionIdleEvent`: published when no messages have been received from that partition in `idlePartitionEventInterval` (if configured).
* `ListenerContainerPartitionNoLongerIdleEvent`: published when a record is consumed from a partition that has previously published a `ListenerContainerPartitionIdleEvent`.
Expand Down
5 changes: 3 additions & 2 deletions ...ka/src/main/java/org/springframework/kafka/event/ListenerContainerPartitionIdleEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2016-2021 the original author or authors.
* Copyright 2016-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -24,6 +24,7 @@
* is configured to do so.
*
* @author Tomaz Fernandes
* @author Borahm Lee
* @since 2.7
*/
public class ListenerContainerPartitionIdleEvent extends KafkaEvent {
Expand Down Expand Up @@ -108,7 +109,7 @@ public boolean isPaused() {

@Override
public String toString() {
return "ListenerContainerIdleEvent [idleTime="
return "ListenerContainerPartitionIdleEvent [idleTime="
+ ((float) this.idleTime / 1000) + "s, listenerId=" + this.listenerId // NOSONAR magic #
+ ", container=" + getSource()
+ ", paused=" + this.paused
Expand Down
7 changes: 4 additions & 3 deletions ...ain/java/org/springframework/kafka/event/ListenerContainerPartitionNoLongerIdleEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2020-2021 the original author or authors.
* Copyright 2020-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -24,6 +24,7 @@
* idle events.
*
* @author Gary Russell
* @author Borahm Lee
* @since 2.6.2
*/
public class ListenerContainerPartitionNoLongerIdleEvent extends KafkaEvent {
Expand Down Expand Up @@ -92,9 +93,9 @@ public String getListenerId() {

@Override
public String toString() {
return "ListenerContainerNoLongerIdleEvent [idleTime="
return "ListenerContainerPartitionNoLongerIdleEvent [idleTime="
+ ((float) this.idleTime / 1000) + "s, listenerId=" + this.listenerId // NOSONAR magic #
+ ", container=" + getSource()
+ ", topicPartitions=" + this.topicPartition + "]";
+ ", topicPartition=" + this.topicPartition + "]";
}
}