GH-2727: Ensure JDBC queries are logged #2730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyrussell
suggested changes
Feb 1, 2019
| this.jdbcOperations.update(this.updateSql, this.sqlParameterSourceFactory.createParameterSource(obj)); | ||
| } | ||
|
|
||
| private static final class PreparedStatementCreatorWithMaxRows implements PreparedStatementCreator, SqlProvider { |
Contributor
There was a problem hiding this comment.
Shouldn't we implement all the delegate's interfaces?
private class PreparedStatementCreatorImpl
implements PreparedStatementCreator, PreparedStatementSetter, SqlProvider, ParameterDisposer {I see code like this in the template...
finally {
if (pss instanceof ParameterDisposer) {
((ParameterDisposer) pss).cleanupParameters();
}
}
Fixes: spring-projects#2727 The `JdbcTemplate` logs a message for the sql to execute when it is supplied by the `QueryProvider`. * Refactor `JdbcPollingChannelAdapter` to use new introduced internal `PreparedStatementCreatorWithMaxRows` with the `QueryProvider` * Refactor `JdbcMessageHandler` to instantiate a `generatedKeysStatementCreator` based on the `PreparedStatementCreatorFactory` * Verify in the `JdbcOutboundGatewayParserTests` that both fixes logs sql queries properly
garyrussell
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2727
The
JdbcTemplatelogs a message for the sql to execute when it issupplied by the
QueryProvider.JdbcPollingChannelAdapterto use new introduced internalPreparedStatementCreatorWithMaxRowswith theQueryProviderJdbcMessageHandlerto instantiate ageneratedKeysStatementCreatorbased on the
PreparedStatementCreatorFactoryJdbcOutboundGatewayParserTeststhat both fixes logssql queries properly