GH-2695: Add proxy option to @EnablePublisher #2701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#2695 To configure a `proxyTargetClass=true` we need declare a `PublisherAnnotationBeanPostProcessor` bean manually, but that may cause a confuse when `@EnablePublisher` is still present. So, target service is proxied twice * Expose `proxyTargetClass` and `order` into the `@EnablePublisher` and `<enable-publisher>` * Refactor `PublisherAnnotationBeanPostProcessor` to extend an `AbstractBeanFactoryAwareAdvisingPostProcessor` to avoid AOP boilerplate code altogether * Add assertion into the `PublisherAnnotationBeanPostProcessor` to be sure that only one of its instance is present in the application context
garyrussell
suggested changes
Jan 17, 2019
Contributor
garyrussell
left a comment
garyrussell
left a comment
There was a problem hiding this comment.
Just a couple of minor polishings...
| catch (NoUniqueBeanDefinitionException ex) { | ||
| throw new BeanCreationNotAllowedException(this.name, | ||
| "Only one 'PublisherAnnotationBeanPostProcessor' bean can be defined in the application context." + | ||
| " Consider do not use '@EnablePublisher' (or '<int:enable-publisher>') if you declare" + |
Contributor
There was a problem hiding this comment.
Do not use '@EnablePublisher' (or '<int:enable-publisher>') if you declare a
| ---- | ||
| ==== | ||
|
|
||
| Starting with version 5.1.3, the `<int:enable-publisher>` component, as well as `@EnablePublisher` annotation are supplied with the `proxy-target-class` and `order` attributes for tuning a `ProxyFactory` configuration. |
Contributor
There was a problem hiding this comment.
as well as the @EnablePublisher ...
s/are supplied with the/have the/
for tuning the ProxyFactory
garyrussell
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2695
To configure a
proxyTargetClass=truewe need declare aPublisherAnnotationBeanPostProcessorbean manually, but that may causea confuse when
@EnablePublisheris still present.So, target service is proxied twice
proxyTargetClassandorderinto the@EnablePublisherand
<enable-publisher>PublisherAnnotationBeanPostProcessorto extend anAbstractBeanFactoryAwareAdvisingPostProcessorto avoid AOP boilerplatecode altogether
PublisherAnnotationBeanPostProcessorto besure that only one of its instance is present in the application context