Skip to content

Sonar fixes according latest report #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 22, 2018
Merged

Sonar fixes according latest report #2676

merged 3 commits into from
Dec 22, 2018

Conversation

@artembilan
Copy link
Member

@artembilan artembilan commented Dec 21, 2018

No description provided.

@artembilan
Copy link
Member Author

artembilan commented Dec 21, 2018

Gary, I think the failure on Travis is related somehow to your latest changes in Spring AMQP we have just recently merged.

Thanks

@garyrussell
Copy link
Contributor

garyrussell commented Dec 21, 2018

Travis

@artembilan
Copy link
Member Author

artembilan commented Dec 21, 2018

Yeah... I see. That's not yours. Sorry: haven't tested before pushing :shame:

@garyrussell
Copy link
Contributor

garyrussell commented Dec 21, 2018

Probably unrelated, but

org.springframework.integration.file.remote.session.DelegatingSessionFactoryTests > testFlow FAILED
    org.springframework.messaging.MessageHandlingException at DelegatingSessionFactoryTests.java:97
        Caused by: org.springframework.messaging.MessagingException at DelegatingSessionFactoryTests.java:97
            Caused by: java.lang.NullPointerException at DelegatingSessionFactoryTests.java:97
org.springframework.integration.file.remote.session.DelegatingSessionFactoryTests > testDelegates FAILED
    java.lang.AssertionError at DelegatingSessionFactoryTests.java:83
org.springframework.integration.file.remote.gateway.RemoteFileOutboundGatewayTests > testLs_f_R_dirs FAILED
    org.springframework.messaging.MessagingException at RemoteFileOutboundGatewayTests.java:423
        Caused by: java.lang.NullPointerException at RemoteFileOutboundGatewayTests.java:423

garyrussell
garyrussell suggested changes Dec 21, 2018
View reviewed changes
...src/main/java/org/springframework/integration/gateway/GatewayMethodInboundMessageMapper.java Outdated
try {
return this.argsMapper.toMessage(new MethodArgsHolder(this.method, arguments), headers);
}
catch (MessagingException e) {
Copy link
Contributor

@garyrussell garyrussell Dec 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a // NOSONAR here - catch and rethrow is discouraged, but needed here.

@garyrussell
Copy link
Contributor

garyrussell commented Dec 21, 2018 

[ant:checkstyle] [ERROR] /home/travis/build/spring-projects/spring-integration/spring-integration-ws/src/main/java/org/springframework/integration/ws/AbstractWebServiceInboundGateway.java:59:24: Reference to instance variable 'headerMapper' needs "this.". [RequireThis]

@artembilan
Sonar fixes according latest report
ed0160f 
* Fix initialization order in the `GatewayMethodInboundMessageMapper`

* Fix mock in the `DelegatingSessionFactoryTests`

* Fix `AbstractRemoteFileOutboundGateway.listFilesInRemoteDir`
@artembilan
* PR comments
79b3a2b
@garyrussell garyrussell merged commit 81b4ea1 into spring-projects:master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@garyrussell garyrussell garyrussell requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artembilan @garyrussell