INT-3364: Add batchUpdate into JdbcMessageHandler #2534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyrussell
suggested changes
Aug 2, 2018
Contributor
garyrussell
left a comment
garyrussell
left a comment
There was a problem hiding this comment.
A couple of typos, and one question.
| if (message.getPayload() instanceof Iterable) { | ||
| Stream<? extends MutableMessage<?>> messageStream = | ||
| StreamSupport.stream(((Iterable<?>) message.getPayload()).spliterator(), false) | ||
| .map(payload -> new MutableMessage<>(payload, message.getHeaders())); |
Contributor
There was a problem hiding this comment.
How about...
Stream<Message<?>> messageStream =
StreamSupport.stream(((Iterable<?>) message.getPayload()).spliterator(), false)
.map(payload -> new Message<Object>() {
@Override
public Object getPayload() {
return payload;
}
@Override
public MessageHeaders getHeaders() {
return message.getHeaders();
}
});...to avoid wrapping the headers in a new map for each iteration?
Member
Author
There was a problem hiding this comment.
Sounds like a good optimization! 👍
Will address a bit later.
Thanks
| * </pre> | ||
| * | ||
| * <p> | ||
| * When message payload is an instance of {@link Iterable}, a |
src/reference/asciidoc/jdbc.adoc
Outdated
| Starting with version 5.1, the `JdbcMessageHandler` performs a `JdbcOperations.batchUpdate()` if the payload of the request message is an `Iterable` instance. | ||
| Each element of the `Iterable` is wrapped to the `MutableMessage` with a copy of headers from the request message. | ||
| In case of regular `SqlParameterSourceFactory`-based configuration these messages are used to build an `SqlParameterSource[]` for an argument used in the mentioned `JdbcOperations.batchUpdate()` function. | ||
| Inb case if `MessagePreparedStatementSetter`, a `BatchPreparedStatementSetter` variant is used to iterate over those messages for each item and provided `MessagePreparedStatementSetter` ise called against them. |
Contributor
There was a problem hiding this comment.
s/Inb/In the/
and the provided
s/ise/is/
* Polishing Docs and Javadocs
garyrussell
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-3364