Skip to content

Conversation

@ritzykey
Copy link
Contributor

markdown error

@pivotal-cla
Copy link

@ritzykey Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 19, 2024
@snicoll
Copy link
Member

snicoll commented Aug 19, 2024

@ritzykey what do you mean by "markdown error"? As far as I understand it, the purpose of /**/ is to replace irrelevant body with ...

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Aug 19, 2024
@ritzykey
Copy link
Contributor Author

Screenshot_20240819-180448_Chrome.jpg

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Aug 19, 2024
@snicoll
Copy link
Member

snicoll commented Aug 19, 2024

@ritzykey what browser and what link is that? This is what I have on Firefox for https://docs.spring.io/spring-boot/reference/web/reactive.html#web.reactive.webflux

image

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Aug 19, 2024
@ritzykey
Copy link
Contributor Author

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Aug 19, 2024
@wilkinsona
Copy link
Member

Thanks, @ritzykey. The code that you have changed is for https://docs.spring.io/spring-boot/reference/web/reactive.html where the problem does not occur. The code for https://docs.spring.io/spring-boot/reference/web/servlet.html is

public class MyUserHandler {
public ServerResponse getUser(ServerRequest request) {
/**/
return ServerResponse.ok().build();
}
public ServerResponse getUserCustomers(ServerRequest request) {
/**/
return ServerResponse.ok().build();
}
public ServerResponse deleteUser(ServerRequest request) {
/**/
return ServerResponse.ok().build();
}

Would you like to update this class instead? The fix is to remove the newlines between /**/ and the return statement so that everything's on one line as it is in the reactive variant:

public class MyUserHandler {
public Mono<ServerResponse> getUser(ServerRequest request) {
/**/ return ServerResponse.ok().build();
}
public Mono<ServerResponse> getUserCustomers(ServerRequest request) {
/**/ return ServerResponse.ok().build();
}
public Mono<ServerResponse> deleteUser(ServerRequest request) {
/**/ return ServerResponse.ok().build();
}

@ritzykey ritzykey closed this Aug 19, 2024
@scottfrederick scottfrederick removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Aug 19, 2024
@snicoll
Copy link
Member

snicoll commented Aug 20, 2024

superseded by #41948

@snicoll snicoll added the status: superseded An issue that has been superseded by another label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: superseded An issue that has been superseded by another

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants