Skip to content

Update access log pattern documentation to align with changes in Tomcat 10 #38403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update access log pattern documentation to align with changes in Tomcat 10 #38403

wants to merge 1 commit into from

Conversation

@jonatan-ivanov
Copy link
Member

@jonatan-ivanov jonatan-ivanov commented Nov 20, 2023

According to the Tomcat docs:

%D - Time taken to process the request in microseconds
%F - Time taken to commit the response, in milliseconds

Which means that in (%D ms) either the placeholder (%F ms) or the unit (%D us) should be changed.

@jonatan-ivanov
Fix Tomcat access log pattern in the docs
3a90542 
According to the Tomcat docs:
%D - Time taken to process the request in microseconds
%F - Time taken to commit the response, in milliseconds

Which means that in "(%D ms)" either the placeholder (%F ms)
or the unit (%D us) should be changed.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 20, 2023
@philwebb
Copy link
Member

philwebb commented Nov 21, 2023

Looks like they changed things in Tomcat 10 (see this note in Tomcat 9 https://tomcat.apache.org/tomcat-8.0-doc/config/valve.html#Access_Logging).

I'd prefer (%D microseconds) I think rather than switching to %F

@philwebb philwebb added for: team-attention An issue we'd like other members of the team to review type: documentation A documentation update and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Nov 21, 2023
@philwebb philwebb added this to the 3.0.x milestone Nov 21, 2023
@philwebb philwebb added the for: merge-with-amendments Needs some changes when we merge label Nov 21, 2023
@philwebb philwebb changed the title Fix Tomcat access log pattern in the docs Update access log pattern documenation to align with changes in Tomcat 10 Nov 21, 2023
@philwebb philwebb changed the title Update access log pattern documenation to align with changes in Tomcat 10 Update access log pattern documentation to align with changes in Tomcat 10 Nov 21, 2023
@philwebb philwebb mentioned this pull request Nov 21, 2023
Closed
philwebb pushed a commit that referenced this pull request Nov 21, 2023
@jonatan-ivanov @philwebb
Update access log pattern to align with Tomcat 10
d5c22b9 
As of Tomcat 10 "%D" changed to mean microseconds instead of
milliseconds.

See gh-38403
@philwebb philwebb closed this in 1e4d605 Nov 21, 2023
@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.13 Nov 21, 2023
@jonatan-ivanov jonatan-ivanov deleted the tomcat-access-pattern-doc-fix branch November 24, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

for: merge-with-amendments Needs some changes when we merge type: documentation A documentation update

Projects

None yet

Milestone

3.0.13

Development

Successfully merging this pull request may close these issues.

4 participants

@jonatan-ivanov @philwebb @wilkinsona @spring-projects-issues