Add auto-configuration for CountedAspect and TimedAspect #37626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
added
the
status: waiting-for-triage
jonatan-ivanov
commented
Sep 29, 2023
| @Bean | ||
| @ConditionalOnMissingBean | ||
| CountedAspect countedAspect(MeterRegistry registry) { | ||
| return new CountedAspect(registry); |
Member
Author
There was a problem hiding this comment.
@marcingrzejszczak Shouldn't we add MeterTagAnnotationHandler to CountedAspect too? Or is it intentionally left out?
Contributor
There was a problem hiding this comment.
FTR: We decided to not get the MeterTagAnnotationHandler in, because that wouldn't make it into RC1. I'm going to merge the PR as it is.
mhalbritter
added
type: enhancement
mhalbritter
pushed a commit
that referenced
this pull request
Oct 2, 2023
Contributor
|
Thank you! |
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #35191, this PR adds support for auto-configuring
CountedAspectandTimedAspect, which enables the usage of@Countedand@Timed.