-
Notifications
You must be signed in to change notification settings - Fork 2.1k
(R) Add bedrock profile autoconfiguration support and replace deprecated #4742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(R) Add bedrock profile autoconfiguration support and replace deprecated #4742
Conversation
ericbottard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jiangbaojun,
Thanks for your contribution!
Could you please update this PR with related tests (likely in BedrockAwsConnectionConfigurationIT) and documentation changes?
| return providerBuilder.profileName(profile.getName()).build(); | ||
| } | ||
| // IAM Role | ||
| return DefaultCredentialsProvider.builder().build(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use an else branch to make it clear that this is the 3rd exclusive case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will update later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ericbottard,
I had added tests and updated the documentation
359eb28 to
e464266
Compare
Signed-off-by: Baojun Jiang <[email protected]>
|
@ericbottard I've finished updating. Could you review it at your convenience? |
|
@ericbottard I saw you prefixed the title with (R). What does it mean? Is there anything I can do? |
Hi @jiangbaojun, |
|
Merged to main as 552263d |
@tzolov Update autoconfiguration, meets the requirements of three connection methods: security key, profile, and IAM Role
DefaultCredentialsProvider.create()was deprecated, replace withDefaultCredentialsProvider.builder().build()example configuration