Remove @Nullable from VectorStore similaritySearch
#3613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VectorStore#similaritySearch methods never return null. There is a data flow issue in the AbstractObservationVectorStore. However, that's only because Micrometer Observation#observe is marked as `@Nullable`, but the value returned is actually the value that the passed supplier returns, which is on control of Spring AI and is never null Signed-off-by: Filip Hrisafov <[email protected]>
spring-builds
pushed a commit
that referenced
this pull request
Jun 25, 2025
The VectorStore#similaritySearch methods never return null, but there's a data flow issue in AbstractObservationVectorStore caused by Micrometer's Observation#observe being marked as @nullable. The returned value is actually controlled by Spring AI's supplier, which never returns null. Fixes #3613 Signed-off-by: Filip Hrisafov <[email protected]> (cherry picked from commit 64cf88a)
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
…#3613) The VectorStore#similaritySearch methods never return null, but there's a data flow issue in AbstractObservationVectorStore caused by Micrometer's Observation#observe being marked as @nullable. The returned value is actually controlled by Spring AI's supplier, which never returns null. Fixes spring-projects#3613 Auto-cherry-pick to 1.0.x Signed-off-by: Filip Hrisafov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VectorStore#similaritySearch methods never return null. There is a data flow issue in the AbstractObservationVectorStore. However, that's only because Micrometer Observation#observe is marked as
@Nullable, but the value returned is actually the value that the passed supplier returns, which is on control of Spring AI and is never null