fix: record option groups to metadata JAR #643
Merged
+190
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes spring-cloud#642 Signed-off-by: Max Brauer <[email protected]>
mamachanko
force-pushed
the
topic/mamachanko/main/option-groups
branch
from
cafb278 to
9004ae8
Compare
onobc
approved these changes
Oct 14, 2025
There was a problem hiding this comment.
Thanks for the fix @mamachanko ! The duplication in the mojo plugin around iteration over files is just killing me BUT it is not because what you have added but rather the other N places where its doing the same thing. I don't have the cycles right now to factor that out though and would have done the same thing you did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #642
Signed-off-by: Max Brauer [email protected]