Skip to content

Supports mTLS for config-server clients #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2024
Merged

Supports mTLS for config-server clients #109

merged 2 commits into from
Mar 22, 2024

Conversation

kvmw
Copy link
Contributor

@kvmw kvmw commented Feb 6, 2024 •
edited
Loading

This PR configures the TLS for the config-server clients, when tls.key, tls.crt and optionally ca.crt are available in bindings.

@kvmw kvmw force-pushed the kvmw/tls-support-for-config-server branch from 09ddb27 to fc0c8a4 Compare February 6, 2024 14:16
anthonydahanne
anthonydahanne reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@anthonydahanne anthonydahanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I could also see it in action thanks to your environment.

I left few minor comments; but one question remains to me: why not adding those certs to the current JVM own keystore and truststore?

Thank you

@anthonydahanne anthonydahanne merged commit e9b5e16 into spring-cloud:main Mar 22, 2024
@kvmw kvmw deleted the kvmw/tls-support-for-config-server branch March 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@anthonydahanne anthonydahanne anthonydahanne left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvmw @anthonydahanne