Major Refactoring #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
having to create one in a temporary directory
to work with kepub.epub Warning : the epub won't be valid anymore.
Fix updating zip without signature in header
--HG-- rename : test/test.phpunit.php => test/epubTest.php
This will fix the downloaded filename with Edge, IE11 if it contains a non ASCII character.
for backwards compatibility. (hopefully)
Composer Packagist support
Allow downloading an updated epub without saving it in a temporary directory
I decided against using DateTime objects since book dates are often not complete. Eg. 1597 is a valid publishing date, but DateTime would fill up this date with the current date. Eg. 1597-07-19 which makes not much sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the whole library to be much cleaner and improves testing a lot.
@seblucas @mbirth it would be very helpful if you could go through this branch and see if you can get your software working with it. And if not tell me what functionality you miss. I hope to publish this to master and packagist soonish.
Todos: