Restore support for list-style source_suffix with third-party parsers
#12584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seen: |
jfbu
approved these changes
Jul 15, 2024
jfbu
reviewed
Jul 25, 2024
| logger.warning(__("The config value `source_suffix' expects " | ||
| "a string, list of strings, or dictionary. " | ||
| "But `%r' is given." % source_suffix)) | ||
| msg = __("The config value `source_suffix' expects a dictionary," |
There was a problem hiding this comment.
Suggested change
| msg = __("The config value `source_suffix' expects a dictionary," | |
| msg = __("The config value `source_suffix' expects a dictionary, " |
|
ping @AA-Turner for missing space in message string... |
|
Thanks! See 0cb3c07 A |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12582
I have also added information/warning messages when
source_suffixis mutated within Sphinx.A