Skip to content

feat: move to netstandard2.0 for full framework support #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

feat: move to netstandard2.0 for full framework support #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@

CS1573: Parameter 'parameter' has no matching param tag in the XML comment for 'parameter' (but other parameters do)
CS1591: Missing XML comment for publicly visible type or member 'Type_or_Member'
CS0436: Type conflicts with imported type. Disabled to allow override of ExcludeFromCodeCoverage with assembly level target.
-->
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>$(NoWarn),1573,1591,1712</NoWarn>
<NoWarn>$(NoWarn),1573,1591,1712,0436</NoWarn>

<!-- Show full paths for the warnings and errors -->
<GenerateFullPaths>true</GenerateFullPaths>
Expand Down
2 changes: 1 addition & 1 deletion src/JUnit.Xml.Package/JUnit.Xml.Package.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</PropertyGroup>

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<Version>$(PackageVersion)</Version>
<AssemblyName>JUnitXml.TestLogger</AssemblyName>

Expand Down
2 changes: 1 addition & 1 deletion src/JUnit.Xml.Package/JUnitXml.TestLogger.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<file src="Microsoft.VisualStudio.TestPlatform.Extension.Junit.Xml.TestLogger.dll" target="build\_common\" />
<file src="Spekt.TestLogger.dll" target="build\_common\" />

<file src="JunitXml.TestLogger.props" target="build\netstandard2.1\" />
<file src="JunitXml.TestLogger.props" target="build\netstandard2.0\" />

<file src="README.md" target="docs\" />
<file src="CHANGELOG.md" target="docs\" />
Expand Down
8 changes: 8 additions & 0 deletions src/JUnit.Xml.TestLogger/Assembly.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,11 @@
using System.Diagnostics.CodeAnalysis;

[assembly: ExcludeFromCodeCoverage]

namespace System.Diagnostics.CodeAnalysis;

[AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Class | AttributeTargets.Constructor | AttributeTargets.Event | AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Struct, AllowMultiple = false, Inherited = false)]
internal sealed class ExcludeFromCodeCoverageAttribute : Attribute
{
public ExcludeFromCodeCoverageAttribute() { }
}
2 changes: 1 addition & 1 deletion src/JUnit.Xml.TestLogger/JUnit.Xml.TestLogger.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>Microsoft.VisualStudio.TestPlatform.Extension.JUnit.Xml.TestLogger</AssemblyName>
<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/NUnit.Xml.Package/NUnit.Xml.Package.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<Version>$(PackageVersion)</Version>
<AssemblyName>NUnitXml.TestLogger</AssemblyName>

Expand Down
8 changes: 8 additions & 0 deletions src/NUnit.Xml.TestLogger/Assembly.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,11 @@
using System.Diagnostics.CodeAnalysis;

[assembly: ExcludeFromCodeCoverage]

namespace System.Diagnostics.CodeAnalysis;

[AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Class | AttributeTargets.Constructor | AttributeTargets.Event | AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Struct, AllowMultiple = false, Inherited = false)]
internal sealed class ExcludeFromCodeCoverageAttribute : Attribute
{
public ExcludeFromCodeCoverageAttribute() { }
}
2 changes: 1 addition & 1 deletion src/NUnit.Xml.TestLogger/NUnit.Xml.TestLogger.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>Microsoft.VisualStudio.TestPlatform.Extension.NUnit.Xml.TestLogger</AssemblyName>
<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
8 changes: 8 additions & 0 deletions src/TestLogger/Assembly.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,11 @@
[assembly: InternalsVisibleTo("Json.TestAdapter")]
[assembly: InternalsVisibleTo("TestLogger.UnitTests")]
[assembly: ExcludeFromCodeCoverage]

namespace System.Diagnostics.CodeAnalysis;

[AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Class | AttributeTargets.Constructor | AttributeTargets.Event | AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Struct, AllowMultiple = false, Inherited = false)]
internal sealed class ExcludeFromCodeCoverageAttribute : Attribute
{
public ExcludeFromCodeCoverageAttribute() { }
}
2 changes: 1 addition & 1 deletion src/TestLogger/TestLogger.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>Spekt.TestLogger</AssemblyName>
<Version>$(PackageVersion)</Version>
<IsPackable>true</IsPackable>
Expand Down
2 changes: 1 addition & 1 deletion src/Xunit.Xml.Package/Xunit.Xml.Package.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<Version>$(PackageVersion)</Version>
<AssemblyName>XunitXml.TestLogger</AssemblyName>

Expand Down
2 changes: 1 addition & 1 deletion src/Xunit.Xml.Package/XunitXml.TestLogger.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
<file src="CHANGELOG.md" target="docs\" />
<file src="packageIcon.png" target="\" />

<file src="XunitXml.TestLogger.props" target="build\netstandard2.1\" />
<file src="XunitXml.TestLogger.props" target="build\netstandard2.0\" />
</files>
</package>
8 changes: 8 additions & 0 deletions src/Xunit.Xml.TestLogger/Assembly.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,11 @@
using System.Diagnostics.CodeAnalysis;

[assembly: ExcludeFromCodeCoverage]

namespace System.Diagnostics.CodeAnalysis;

[AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Class | AttributeTargets.Constructor | AttributeTargets.Event | AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Struct, AllowMultiple = false, Inherited = false)]
internal sealed class ExcludeFromCodeCoverageAttribute : Attribute
{
public ExcludeFromCodeCoverageAttribute() { }
}
2 changes: 1 addition & 1 deletion src/Xunit.Xml.TestLogger/Xunit.Xml.TestLogger.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>Microsoft.VisualStudio.TestPlatform.Extension.Xunit.Xml.TestLogger</AssemblyName>
<Version>$(PackageVersion)</Version>
<IsPackable>false</IsPackable>
Expand Down
2 changes: 1 addition & 1 deletion test/Json.TestLogger.Package/Json.TestLogger.Package.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<Version>$(PackageVersion)</Version>
<AssemblyName>Sample.Json.TestLogger</AssemblyName>

Expand Down
2 changes: 1 addition & 1 deletion test/Json.TestLogger.TestAdapter/Json.TestLogger.TestAdapter.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>Json.TestAdapter</AssemblyName>
<Version>$(PackageVersion)</Version>
<IsPackable>false</IsPackable>
Expand Down
2 changes: 1 addition & 1 deletion test/Json.TestLogger/Json.TestLogger.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>Json.TestLogger</AssemblyName>
<Version>$(PackageVersion)</Version>
<IsPackable>false</IsPackable>
Expand Down
Loading