junit doesn't work when running tests with n472

[appel1]

Describe the bug
A clear and concise description of what the bug is.

• NUnit
• net472;net8.0
• dotnet test --no-build --logger:"junit" --results-directory artifacts/test-reports
• Windows

Using NUnit for a test project targeting both net472 and net8.0.

    <PackageReference Include="NUnit" Version="4.3.2" />
    <PackageReference Include="NUnit3TestAdapter" Version="5.0.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
    <PackageReference Include="JunitXml.TestLogger" Version="6.0.0" />

Could not find a test logger with AssemblyQualifiedName, URI or FriendlyName 'junit'.
  Example.Tests test net472 failed with 1 error(s) (0,2s)
    C:\Program Files\dotnet\sdk\9.0.200\Microsoft.TestPlatform.targets(48,5): error MSB6006: "dotnet.exe" exited with code 1.
NUnit Adapter 5.0.0.0: Test execution started
Running all tests in E:\dev\Example\artifacts\bin\Example.Tests\debug_net8.0\Example.Tests.dll
   NUnit3TestExecutor discovered 72 of 72 NUnit test cases using Current Discovery mode, Non-Explicit run
NUnit Adapter 5.0.0.0: Test execution complete
Results File: E:\dev\Example\artifacts\test-reports\TestResults.xml
  Example.Tests test net8.0 succeeded (3,4s)

Test summary: total: 72; failed: 0; succeeded: 72; skipped: 0; duration: 3,4s
Build failed with 1 error(s) in 3,8s

Expected behavior
Success for both net472 and net8.0 targets.

[codito]

@appel1 with v6.x, this logger targets netstandard2.1. It doesn't support .NET full framework targets (net472). net80 should be fully supported. Please see #158 for a discussion.

Please use 5.x if you have a test project targeting the .NET full framework.

[codito]

We have a potential fix for this merged in master.

Would it be possible for you to try this pre-release package and confirm if it works?
https://www.myget.org/feed/spekt/package/nuget/JunitXml.TestLogger

[appel1]

Looks good.

> dotnet test --no-build --logger:"junit;LogFilePath=artifacts/test-reports/testreport-{framework}.xml" --results-directory artifacts/test-reports
NUnit Adapter 5.0.0.0: Test execution started
Running all tests in E:\dev\Example\artifacts\bin\Example.Tests\debug_net8.0\Example.Tests.dll
   NUnit3TestExecutor discovered 72 of 72 NUnit test cases using Current Discovery mode, Non-Explicit run
NUnit Adapter 5.0.0.0: Test execution started
Running all tests in E:\dev\Example\artifacts\bin\Example.Tests\debug_net472\Example.Tests.dll
   NUnit3TestExecutor discovered 72 of 72 NUnit test cases using Current Discovery mode, Non-Explicit run
NUnit Adapter 5.0.0.0: Test execution complete
Results File: artifacts/test-reports/testreport-NETCoreApp80.xml
  Example.Tests test net8.0 succeeded (3,5s)
NUnit Adapter 5.0.0.0: Test execution complete
Results File: artifacts/test-reports/testreport-NETFramework472.xml
  Example.Tests test net472 succeeded (6,4s)

Test summary: total: 144; failed: 0; succeeded: 144; skipped: 0; duration: 6,4s
Build succeeded in 6,8s

[viceice]

🤔 I now tried the NunitXml.TestLogger v6 on a net48 test project and it worked 🤔

$ dotnet test .\test\XXX.Test\ -f net48
A total of 1 test files matched the specified pattern.
NUnit Adapter 5.0.0.0: Test execution started
Running all tests in ~\test\XXX.Test\bin\Debug\net48\XXX.Test.dll
   NUnit3TestExecutor discovered 88 of 88 NUnit test cases using Current Discovery mode, Non-Explicit run

...

NUnit Adapter 5.0.0.0: Test execution complete

Passed!  - Failed:     0, Passed:    88, Skipped:     0, Total:    88, Duration: 6 s - XXX.Test.dll (net48)
Results File: ~\test\XXX.Test\TestResults\XXX.Test.NETFramework48.nunit.xml

Centrally managed packages:

    <PackageVersion Include="NUnit" Version="4.3.2" />
    <PackageVersion Include="NUnit.Analyzers" Version="4.6.0" />
    <PackageVersion Include="NUnit3TestAdapter" Version="5.0.0" />
    <PackageVersion Include="NunitXml.TestLogger" Version="6.0.0" />

[viceice]

oh, you didn't published the changes for the nunit logger 🤔

https://www.nuget.org/packages/NunitXml.TestLogger/6.0.0#supportedframeworks-body-tab 👈 still net45 and netstandard1.0

[codito]

@viceice please try this pre-release package for NUnit logger: https://www.myget.org/feed/spekt/package/nuget/NunitXml.TestLogger

This has the latest fix from master. If all looks good, will push it to nuget over the weekend.

[codito]

v6.1.0 is released to NuGet with netstandard2.0 support. Thanks again for reporting the issue and validating the fix.

https://www.nuget.org/packages/JunitXml.TestLogger/
https://www.nuget.org/packages/NunitXml.TestLogger/

[viceice]

works, thanks 🙏