Skip to content

Conversation

bact
Copy link
Contributor

@bact bact commented Sep 4, 2024

What this PR does

Pre-requisite

  • A gh-pages branch in GitHub repo is needed for publication to https://spdx.github.io/using/
  • The branch has to be created before the workflow starts

After merge (Optional)

  • After merge, the redirect map on the spdx-spec repo can be updated to make the old Annex links redirected to pages in the SPDX Using website.

Details

bact added 28 commits September 4, 2024 10:11
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Fix dir names and remove PDF plugin
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact closed this Sep 4, 2024
@bact bact reopened this Sep 4, 2024
@bact bact closed this Sep 4, 2024
@bact bact changed the title Setup mkdocs Setup website for SPDX Using (workflow with mkdocs) Sep 4, 2024
bact added 2 commits September 4, 2024 16:57
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact reopened this Sep 4, 2024
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Copy link
Contributor Author

bact commented Sep 4, 2024

This PR is to setup https://spdx.github.io/using/ - Please review @licquia @zvr @goneall @kestewart

bact added 3 commits September 4, 2024 17:41
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@zvr
Copy link
Member

zvr commented Sep 10, 2024

May I suggest that we simplify our lives and do not use mkdocs for this repo?

This is simply a collection of independent texts, no need to generate a single website. There is not even an ordering of the texts.

Why don't we simply move them all to wiki pages?

@bact
Copy link
Contributor Author

bact commented Sep 10, 2024

@bact
Copy link
Contributor Author

bact commented Sep 10, 2024

If we're going to use GitHub wiki, may be it's even possible to use the wiki of spdx-spec repo?

@zvr
Copy link
Member

zvr commented Sep 10, 2024

My vote/preference would be to leave the spec repo for spec stuff (actual specification), and have supporting documentation elsewhere...

@goneall
Copy link
Member

goneall commented Dec 10, 2024

Discussed on the tech call 10 Dec 2024:

  • We would need to do some admin work - permissions etc. for the Wiki
  • Existing markdown would need to be translated
  • May be work work than Markdown
  • Sharing links would be easier with the published markdown
  • Downside with the markdown is more maint.
  • Joshua prefers markdown
  • Markdown is more portable
  • Henk - prefers markdown
  • Sean - prefers markdown
  • Can do pull requests

General consensus on the call is Markdown - but we don't have full representation of contributor using

@zvr
Copy link
Member

zvr commented Dec 10, 2024

@goneall sorry, since I wasn't in the call, I am not sure I understood what was discussed from the comment above.
Lots of people "prefer markdown", but what does that mean?
We will obviously use Markdown, one way or another -- that's what GitHub supports. I hope no one made a point of moving to RST.

The question should be: do we have markdown files/pages in a "wiki" (e.g. automatically published by GitHub) or do we have markdown files that are processed and published by our own infrastructure (mkdocs or something else) in custom workflows?

@goneall
Copy link
Member

goneall commented Dec 10, 2024

@goneall sorry, since I wasn't in the call, I am not sure I understood what was discussed from the comment above. Lots of people "prefer markdown", but what does that mean? We will obviously use Markdown, one way or another -- that's what GitHub supports. I hope no one made a point of moving to RST.

The question should be: do we have markdown files/pages in a "wiki" (e.g. automatically published by GitHub) or do we have markdown files that are processed and published by our own infrastructure (mkdocs or something else) in custom workflows?

@zvr - on the call, I don't think we had a good idea on what is involved in the "wiki" - we were assuming it was not markdown. I think we should replay the conversation once you're on the call. Perhaps you can give us a demo of what the wiki workflow would look like.

Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job - LGTM

@kestewart
Copy link
Collaborator

This looks excellent, Art.

@swinslow
Copy link
Member

+1, this is great!

@kestewart
Copy link
Collaborator

Given I'm not seeing any disagreement, going ahead and merging this.

@kestewart kestewart merged commit ae57e8d into spdx:main Oct 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up mkdocs

7 participants