-
Notifications
You must be signed in to change notification settings - Fork 177
Test update following WFSS FITS unit change #9667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test update following WFSS FITS unit change #9667
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9667 +/- ##
=======================================
Coverage 80.37% 80.37%
=======================================
Files 367 367
Lines 37265 37265
=======================================
Hits 29951 29951
Misses 7314 7314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are actually two instances of expected_units and you've only changed one of them. that's why the unit tests are still failing even when pointing to your stdatamodels branch
Updated RT after getting the second degrees check fixed: https://github.com/spacetelescope/RegressionTests/actions/runs/16379943864 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending approval of the stdatamodels PR
don't forget to point stdatamodels back to main
all the regtest failures make sense, they're just pointing out the unit changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending merge of the stdatamodels PR and pyproject.toml update.
@meeseeksdev backport to release/1.19.x |
…S FITS unit change) (#9673) Co-authored-by: Tyler Pauly <[email protected]>
Related to JP-3931
This PR follows from spacetelescope/stdatamodels#529 , which modified the unit string for WFSS tables. This updates the truth to get passing tests.
Tasks
Build 12.0
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see changelog readme for instructions)docs/
pageokify_regtests
to update the truth files