Skip to content

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented May 1, 2025

Resolves JP-3899

Closes #9231

This PR removes the unused cube skymatch step.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@github-actions github-actions bot added stpipe installation cube_skymatch mrs_imatch automation Continuous Integration (CI) and testing automation tools labels May 1, 2025
@emolter
Copy link
Collaborator Author

emolter commented May 1, 2025

regression test started here https://github.com/spacetelescope/RegressionTests/actions/runs/14778281877

edit: all passing

@emolter emolter added this to the Build 12.0 milestone May 1, 2025
Copy link

codecov bot commented May 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.57%. Comparing base (cabaee0) to head (e2c8621).
⚠️ Report is 690 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9426      +/-   ##
==========================================
+ Coverage   75.99%   76.57%   +0.58%     
==========================================
  Files         368      364       -4     
  Lines       37020    36626     -394     
==========================================
- Hits        28133    28047      -86     
+ Misses       8887     8579     -308     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter emolter marked this pull request as ready for review May 1, 2025 16:48
@emolter emolter requested review from a team as code owners May 1, 2025 16:48
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for tidying up!

@emolter emolter enabled auto-merge (squash) May 1, 2025 19:06
@emolter emolter merged commit 8df962f into spacetelescope:main May 1, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools cube_skymatch installation mrs_imatch stpipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update or remove cube_skymatch
2 participants