JP-3989 cube build bug

[jemorrison]

Resolves JP-3989

Closes #9415

This PR addresses removes how a dictionary is setup. A reassignment of a values in the pipeline caused an error in some pipeline tests.

Tasks

• If you have a specific reviewer in mind, tag them.
• add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job ([click here for instructions]
    Regression tests passing: https://github.com/spacetelescope/RegressionTests/actions/runs/14715951406
  • (https://github.com/spacetelescope/RegressionTests/blob/main/docs/running_regression_tests.md))
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.62%. Comparing base (02057da) to head (4c00e00).
⚠️ Report is 701 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9416   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files         368      368           
  Lines       36906    36894   -12     
=======================================
- Hits        27910    27902    -8     
+ Misses       8996     8992    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[melanieclarke]

It looks like style checks are failing because the old lines are commented instead of removed. Can you please clean those up and run regtests? It would be nice to get this in - it is blocking regtest runs for PRs.

[jemorrison]

@melanieclarke I did not add these lines - they have been there for ages. So I left them commented because I wanted to run the regression test first to make sure they are not needed. We must have made a change someplace that now gives these lines as an error.
The regression tests ran fine with the lines commented out. So now I will remove the lines and run the regression tests again. I wanted to do this in steps.

[melanieclarke]

Sounds good, thanks! I know they're not new, they were just re-noticed by the sonar scan because of the unrelated style changes in those lines.

[jemorrison]

@melanieclarke regression tests passing: https://github.com/spacetelescope/RegressionTests/actions/runs/14715951406

[melanieclarke]

Thanks for the quick fix!