Fix logging message in NIRSpec assign_wcs and turn all invalid interval warning into error

[pllim]

Resolves JP-3932

This PR addresses #3116

I don't think this needs a change log?

Tasks

• If you have a specific reviewer in mind, tag them.
• add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions) https://github.com/spacetelescope/RegressionTests/actions/runs/14718762321 and https://github.com/spacetelescope/RegressionTests/actions/runs/14735628096
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.63%. Comparing base (1c227fb) to head (fe4369a).
⚠️ Report is 690 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9412   +/-   ##
=======================================
  Coverage   75.63%   75.63%           
=======================================
  Files         368      368           
  Lines       36900    36900           
=======================================
  Hits        27908    27908           
  Misses       8992     8992           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pllim]

8189 warnings, 70 errors 😱

Note to self:

  File "jwst/assign_wcs/nirspec.py", line 2214, in _nrs_wcs_set_input_lite
    slit_wcs.bounding_box = bb

[melanieclarke]

For the logging message - I think we want the original message to stay as it is, for its primary use in assign_wcs. We just want the messages from msa_flagging to say something different. I was envisioning something like temporarily turning off the log while calling the assign_wcs function, and separately logging the total number of failed open shutters.

[pllim]

Thanks for the clarification, @melanieclarke .

What about the side discussion on "Invalid interval"? Should I ignore that for now or you want that fixed in the same PR?

[melanieclarke]

Thanks for the clarification, @melanieclarke .

What about the side discussion on "Invalid interval"? Should I ignore that for now or you want that fixed in the same PR?

Let's go ahead and get that fixed too.

[melanieclarke]

I think this looks good now, thanks!

Can you please add a change log, though? This will change the user-facing logs and addresses a long-standing request for the pipeline, so I think it's worth noting.

[melanieclarke]

Latest regtests are clean. Thanks!

[pllim]