JP-3855 Update code style for spectral_leak step

[jemorrison]

Helps to resolve JP-3857

This PR updates the spectral leak step for code style changes.

Tasks

• If you have a specific reviewer in mind, tag them.
• add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job ([click here for instructions]
  • regression test pass:https://github.com/spacetelescope/RegressionTests/actions/runs/14391771207
  • (https://github.com/spacetelescope/RegressionTests/blob/main/docs/running_regression_tests.md))
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[codecov]

Codecov Report

Attention: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.

Project coverage is 75.58%. Comparing base (5ea9959) to head (b3bed53).
Report is 664 commits behind head on main.

Files with missing lines	Patch %	Lines
jwst/spectral_leak/spectral_leak_step.py	7.69%	24 Missing ⚠️
jwst/spectral_leak/spectral_leak.py	0.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9395   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files         368      368           
  Lines       36898    36898           
=======================================
  Hits        27890    27890           
  Misses       9008     9008           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jemorrison]

Regression test pass: https://github.com/spacetelescope/RegressionTests/actions/runs/14391771207

[melanieclarke]

Looks good! It looks like there are no unit tests for this module, but there are regression tests that run this step, so we should be okay for basic code exercise.

Just one quick suggestion for clarity in the docs.

[kmacdonald-stsci]

I have some recommendations, but it looks fine.

[melanieclarke]

@jemorrison - there are two small clean up comments here that still need addressing, then I think we should be ready to merge this one.

[jemorrison]

@melanieclarke Sorry I can not find the cleanup you say that still need addressing ?
I change the input_model one and moved the comments to the before the code that Ken suggested.

[jemorrison]

@melanieclarke I think I did not commit those changes so that might be the problem

[melanieclarke]

All good now, thanks for the updates.