BUG: Fix is_nrs_msaspec_flatlamp and remove redundant if-else in gs_position_acq

[pllim]

This PR addresses two checks that SonarQube isn't happy about. Not new stuff but still good to fix. Since the bug been there for 5 years and no one complained, probably no need with change log.

Tasks

• If you have a specific reviewer in mind, tag them.
• add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions) https://github.com/spacetelescope/RegressionTests/actions/runs/14382345024
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[melanieclarke]

Looks good, pending clean regtests. Thanks!

[pllim]

Looks like RT got past Sonar https://github.com/spacetelescope/RegressionTests/actions/runs/14382345024

[melanieclarke]

Looks like RT got past Sonar https://github.com/spacetelescope/RegressionTests/actions/runs/14382345024

Yes, but so did the previous runs, so I'm not sure I trust the sonar scan on PRs!

[pllim]

So, we won't actually know until after merge and run RT from main?

[melanieclarke]

So, we won't actually know until after merge and run RT from main?

Seems like. I'll file a ticket on RegressionTests to look into this. I really dislike finding problems after merge.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.39%. Comparing base (c15c667) to head (5bc305b).
Report is 650 commits behind head on main.

Files with missing lines	Patch %	Lines
jwst/lib/exposure_types.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9389      +/-   ##
==========================================
- Coverage   75.42%   75.39%   -0.03%     
==========================================
  Files         368      368              
  Lines       36852    36842      -10     
==========================================
- Hits        27795    27777      -18     
- Misses       9057     9065       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[melanieclarke]

Regtests are clean. Thanks for the quick fix!

[melanieclarke]

Sonar scan on main now passes:
https://github.com/spacetelescope/RegressionTests/actions/runs/14369253521