MNT: Forward-port of PR 9374 and PR 9379 (Metadata release 1.18.0) #9382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9382 +/- ##
==========================================
- Coverage 75.40% 75.40% -0.01%
==========================================
Files 368 368
Lines 36839 36837 -2
==========================================
- Hits 27779 27777 -2
Misses 9060 9060 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pllim
commented
Apr 9, 2025
kmacdonald-stsci
approved these changes
Apr 9, 2025
pllim
force-pushed
the
forwardport-jhunk-1.18.0
branch
from
826c265 to
41c4e05
Compare
Remove changelog fragments like spacetelescope#9354 except the one whose backport was reverted
pllim
force-pushed
the
forwardport-jhunk-1.18.0
branch
from
41c4e05 to
fda0180
Compare
|
Okay I removed the fragments. I think this is ready to merge unless you catch something else. |
pllim
commented
Apr 9, 2025
requirements-sdp.txt
Outdated
There was a problem hiding this comment.
This update is not needed if #9386 is merged first.
pllim
commented
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forward-ports
to keep
maincontent somewhat in-sync with latest release so the former does not appear outdated.Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files