JP-3905 add option to save shower model in straylight step for MIRI MRS data

[jemorrison]

Resolves JP-3905

Closes #9240

This PR adds an option to the straylight step to save the shower model when also running the clean_shower option.
A new regression test running straylight with clean_showers and save_shower_model = True.
New regression Truth files were added to the regression test suite.

Tasks

• If you have a specific reviewer in mind, tag them.
• add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job ([click here for instructions]
    Regression tests passed:
    https://github.com/spacetelescope/RegressionTests/actions/runs/14474571962
  • (https://github.com/spacetelescope/RegressionTests/blob/main/docs/running_regression_tests.md))
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[jemorrison]

Running the regression tests and I will add a test to compare the shower model

[jemorrison]

Oh I need to probably update the docs to add this new parameter. I will do that.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.58%. Comparing base (233ff95) to head (5ea9959).
Report is 678 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9378      +/-   ##
==========================================
+ Coverage   75.37%   75.58%   +0.21%     
==========================================
  Files         368      368              
  Lines       36885    36898      +13     
==========================================
+ Hits        27802    27890      +88     
+ Misses       9083     9008      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jemorrison]

running regression tests with new test.

[jemorrison]

Regression tests passed:
https://github.com/spacetelescope/RegressionTests/actions/runs/14390164520

[melanieclarke]

Testing locally, it looks like the file is saved as expected. Thanks for updating the docs and adding the new test as well!

It would be nice to add a unit test for the new output, as well as the regression test, to make sure it gets saved in the right location when output_dir is specified.

A few more comments and requests below.

[melanieclarke]

Checking in on your updates... A couple more clean up items remaining, and another follow up request for the regtest.

Looks like the unit test is still not working because: "Straylight correction not defined for datatype CubeModel". It will need a different synthetic input than the other unit test.

[jemorrison]

@ re-running regression tests

[melanieclarke]

I'll rerun regtests one more time at the same link, but then I think this should be good to go.

[melanieclarke]

All good now!