-
Notifications
You must be signed in to change notification settings - Fork 177
JP-3686: Test using source catalog output as tweakreg abs_refcat #9301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Starting regression tests here https://github.com/spacetelescope/RegressionTests/actions/runs/13933300906 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9301 +/- ##
==========================================
- Coverage 74.69% 74.62% -0.08%
==========================================
Files 369 369
Lines 37105 37152 +47
==========================================
+ Hits 27717 27726 +9
- Misses 9388 9426 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tiny comment; the 'Alignment' section of README.rst now has some duplicated/conflicting information. Paragraph 2 adds the new comment about catalog needing either RA/DEC or sky_centroid, but paragraph 4 still says that it must contain RA/DEC. We should condense these paragraphs. |
@drlaw1558 How does 40567f3 look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@meeseeksdev backport to release/1.18.x |
…utput as tweakreg abs_refcat
…e catalog output as tweakreg abs_refcat) (#9346) Co-authored-by: Ned Molter <[email protected]>
…ng sourc…" This reverts commit 6406ed5.
…ng source catalog output as tweakreg abs_refcat)" (#9375)
Given #9375 , I updated the milestone. |
Provides test coverage for JP-3686. See that issue's GitHub mirror at #8639
The changes associated with that ticket are in stcal, but a regtest is needed to prevent future bugs like the one discussed in the ticket comments, which is resolved by spacetelescope/stcal#355.
This PR adds a regression test that takes the output
_cat.ecsv
file directly from a run of theSourceCatalogStep
and injects it back intoTweakRegStep
as theabs_refcat
parameter.I confirmed that the test fails on the current stable release of stcal, but passes with the bugfix in spacetelescope/stcal#355, so it indeed tests what it is intended to test.
This PR also adds better documentation of the
abs_refcat
andcatfile
parameters.Tasks
Build 11.3
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesnews fragment change types...
changes/<PR#>.general.rst
: infrastructure or miscellaneous changechanges/<PR#>.docs.rst
changes/<PR#>.stpipe.rst
changes/<PR#>.datamodels.rst
changes/<PR#>.scripts.rst
changes/<PR#>.set_telescope_pointing.rst
changes/<PR#>.pipeline.rst
stage 1
changes/<PR#>.group_scale.rst
changes/<PR#>.dq_init.rst
changes/<PR#>.emicorr.rst
changes/<PR#>.saturation.rst
changes/<PR#>.ipc.rst
changes/<PR#>.firstframe.rst
changes/<PR#>.lastframe.rst
changes/<PR#>.reset.rst
changes/<PR#>.superbias.rst
changes/<PR#>.refpix.rst
changes/<PR#>.linearity.rst
changes/<PR#>.rscd.rst
changes/<PR#>.persistence.rst
changes/<PR#>.dark_current.rst
changes/<PR#>.charge_migration.rst
changes/<PR#>.jump.rst
changes/<PR#>.clean_flicker_noise.rst
changes/<PR#>.ramp_fitting.rst
changes/<PR#>.gain_scale.rst
stage 2
changes/<PR#>.assign_wcs.rst
changes/<PR#>.badpix_selfcal.rst
changes/<PR#>.msaflagopen.rst
changes/<PR#>.nsclean.rst
changes/<PR#>.imprint.rst
changes/<PR#>.background.rst
changes/<PR#>.extract_2d.rst
changes/<PR#>.master_background.rst
changes/<PR#>.wavecorr.rst
changes/<PR#>.srctype.rst
changes/<PR#>.straylight.rst
changes/<PR#>.wfss_contam.rst
changes/<PR#>.flatfield.rst
changes/<PR#>.fringe.rst
changes/<PR#>.pathloss.rst
changes/<PR#>.barshadow.rst
changes/<PR#>.photom.rst
changes/<PR#>.pixel_replace.rst
changes/<PR#>.resample_spec.rst
changes/<PR#>.residual_fringe.rst
changes/<PR#>.cube_build.rst
changes/<PR#>.extract_1d.rst
changes/<PR#>.resample.rst
stage 3
changes/<PR#>.assign_mtwcs.rst
changes/<PR#>.mrs_imatch.rst
changes/<PR#>.tweakreg.rst
changes/<PR#>.skymatch.rst
changes/<PR#>.exp_to_source.rst
changes/<PR#>.outlier_detection.rst
changes/<PR#>.tso_photometry.rst
changes/<PR#>.stack_refs.rst
changes/<PR#>.align_refs.rst
changes/<PR#>.klip.rst
changes/<PR#>.spectral_leak.rst
changes/<PR#>.source_catalog.rst
changes/<PR#>.combine_1d.rst
changes/<PR#>.ami.rst
other
changes/<PR#>.wfs_combine.rst
changes/<PR#>.white_light.rst
changes/<PR#>.cube_skymatch.rst
changes/<PR#>.engdb_tools.rst
changes/<PR#>.guider_cds.rst