JP-3719: Fix names for intermediate spectral outlier detection files #8735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3719
Closes #8734
For spectral modes with resampling, intermediate files from outlier detection are not being written correctly. There should be files written to the output directory with suffix 'outlier_s2d'. Instead, there are currently files written to the current directory with suffix 'outlier_i2d', and some duplicate files written to the output directory with suffix 'outlier__outlier_s2d.fits'.
This PR should fix these issues by:
I also added a unit test for spectral outlier detection, along with some checks for these kinds of regressions in intermediate file saving.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR