Skip to content

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Aug 20, 2024

This PR adds the changelog to the sphinx documentation.

https://jwst-pipeline--8716.org.readthedocs.build/en/8716/jwst/changes.html

Adding the file to sphinx revealed many formatting issues in CHANGES.rst fixed in this PR.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@braingram braingram marked this pull request as ready for review August 20, 2024 20:34
@braingram braingram requested a review from a team as a code owner August 20, 2024 20:34
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.38%. Comparing base (aeb7469) to head (f860547).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8716      +/-   ##
==========================================
+ Coverage   60.36%   60.38%   +0.01%     
==========================================
  Files         372      372              
  Lines       38338    38337       -1     
==========================================
+ Hits        23142    23148       +6     
+ Misses      15196    15189       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea to me! Thanks for fixing all the formatting errors as well.

@braingram braingram merged commit 9667e6c into spacetelescope:master Aug 27, 2024
29 checks passed
@braingram braingram deleted the docs_changes branch August 27, 2024 20:37
@nden nden added this to the Build 11.1 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants